Non english letters

Reads 2344 • Replies 34 • Started Tuesday, October 17, 2017 3:42:51 PM CT

The forums you're viewing are the static, archived version. You won't be able to post or reply here.
Our new, modern forums are here:
RateBeer Forums

Thread Frozen
 
Bitterbill
beers 2826 º places 25 º 18:56 Tue 10/17/2017

Originally posted by LazyPyro
Microsoft... that explains it. Notoriously inconsistent with character encoding.

Romanian is another charset that needs fixing. Currently some beers are impossible to find unless you know the brewery name (not always obvious for macros). For example Timișoreana. Searching either Timișoreana with the correct s or Timisoreana... neither return any results at all. The only way to get to them is a Google search, or by going to the Ursus brewery page first assuming users know it's brewed there.


Found it in a snap on BA. Just saying.
Ratebeer can do it too !

 
joet
admin
beers 2898 º places 125 º 19:22 Tue 10/17/2017

Originally posted by Bill Becker
Originally posted by LazyPyro
Microsoft... that explains it. Notoriously inconsistent with character encoding.

Romanian is another charset that needs fixing. Currently some beers are impossible to find unless you know the brewery name (not always obvious for macros). For example Timișoreana. Searching either Timișoreana with the correct s or Timisoreana... neither return any results at all. The only way to get to them is a Google search, or by going to the Ursus brewery page first assuming users know it's brewed there.


Found it in a snap on BA. Just saying.
Ratebeer can do it too !


And we have

https://www.ratebeer.com/findbeer.asp?beername=timisoreana
https://www.ratebeer.com/findbeer.asp?beername=Timișoreana

But again now that we have this fixed, we'll be needed to save all beers and brewers to make this count.

Thanks for the heads up on the Romanian character. I will move through these later to ensure we have them all.

 
joet
admin
beers 2898 º places 125 º 19:28 Tue 10/17/2017

Originally posted by LazyPyro
Microsoft... that explains it. Notoriously inconsistent with character encoding.

Romanian is another charset that needs fixing. Currently some beers are impossible to find unless you know the brewery name (not always obvious for macros). For example Timișoreana. Searching either Timișoreana with the correct s or Timisoreana... neither return any results at all. The only way to get to them is a Google search, or by going to the Ursus brewery page first assuming users know it's brewed there.


I fixed this beer but you can also do partial searches if you need to.
I searched for oreana in order to find the beer and make the fix.

Thanks for the heads up!

 
Bitterbill
beers 2826 º places 25 º 19:40 Tue 10/17/2017

Originally posted by joet
Originally posted by Bill Becker
Originally posted by LazyPyro
Microsoft... that explains it. Notoriously inconsistent with character encoding.

Romanian is another charset that needs fixing. Currently some beers are impossible to find unless you know the brewery name (not always obvious for macros). For example Timișoreana. Searching either Timișoreana with the correct s or Timisoreana... neither return any results at all. The only way to get to them is a Google search, or by going to the Ursus brewery page first assuming users know it's brewed there.


Found it in a snap on BA. Just saying.
Ratebeer can do it too !


And we have

https://www.ratebeer.com/findbeer.asp?beername=timisoreana
https://www.ratebeer.com/findbeer.asp?beername=Timișoreana

But again now that we have this fixed, we'll be needed to save all beers and brewers to make this count.

Thanks for the heads up on the Romanian character. I will move through these later to ensure we have them all.




Way to go!

 
LazyPyro
beers 5290 º places 59 º 20:12 Tue 10/17/2017

Originally posted by joet
Originally posted by Bill Becker
Originally posted by LazyPyro
Microsoft... that explains it. Notoriously inconsistent with character encoding.

Romanian is another charset that needs fixing. Currently some beers are impossible to find unless you know the brewery name (not always obvious for macros). For example Timișoreana. Searching either Timișoreana with the correct s or Timisoreana... neither return any results at all. The only way to get to them is a Google search, or by going to the Ursus brewery page first assuming users know it's brewed there.


Found it in a snap on BA. Just saying.
Ratebeer can do it too !


And we have

https://www.ratebeer.com/findbeer.asp?beername=timisoreana
https://www.ratebeer.com/findbeer.asp?beername=Timișoreana

But again now that we have this fixed, we'll be needed to save all beers and brewers to make this count.

Thanks for the heads up on the Romanian character. I will move through these later to ensure we have them all.


Excellent! And yes you need to do it for the letter t-comma as well: ț

For example this brewery is difficult to find without a partial search term as you point out https://www.ratebeer.com/brewers/ber259ria-vlad-538epe537/28164/

This beer was redundantly named to get around the problem: https://www.ratebeer.com/beer/ha539egana-hategana/84895/

The city of Constanța has dropped the ț for a normal t https://www.ratebeer.com/places/city/constanta/0/167/

I suspect there's others too I'll test more later.

Strangely, the other letters in the Romanian alphabet appear to be working correctly already. For example a search for Zaganu will bring up all all Zăganu beers.

So should I go through and report every beer and brewery with a ț or ș in them so an admin can re-save it? Or is this something you can do automatically? There's quite a lot...

 
joet
admin
beers 2898 º places 125 º 22:22 Tue 10/17/2017

Originally posted by LazyPyro
Originally posted by joet
Originally posted by Bill Becker
Originally posted by LazyPyro
Microsoft... that explains it. Notoriously inconsistent with character encoding.

Romanian is another charset that needs fixing. Currently some beers are impossible to find unless you know the brewery name (not always obvious for macros). For example Timișoreana. Searching either Timișoreana with the correct s or Timisoreana... neither return any results at all. The only way to get to them is a Google search, or by going to the Ursus brewery page first assuming users know it's brewed there.


Found it in a snap on BA. Just saying.
Ratebeer can do it too !


And we have

https://www.ratebeer.com/findbeer.asp?beername=timisoreana
https://www.ratebeer.com/findbeer.asp?beername=Timișoreana

But again now that we have this fixed, we'll be needed to save all beers and brewers to make this count.

Thanks for the heads up on the Romanian character. I will move through these later to ensure we have them all.


Excellent! And yes you need to do it for the letter t-comma as well: ț

For example this brewery is difficult to find without a partial search term as you point out https://www.ratebeer.com/brewers/ber259ria-vlad-538epe537/28164/

This beer was redundantly named to get around the problem: https://www.ratebeer.com/beer/ha539egana-hategana/84895/

The city of Constanța has dropped the ț for a normal t https://www.ratebeer.com/places/city/constanta/0/167/

I suspect there's others too I'll test more later.

Strangely, the other letters in the Romanian alphabet appear to be working correctly already. For example a search for Zaganu will bring up all all Zăganu beers.

So should I go through and report every beer and brewery with a ț or ș in them so an admin can re-save it? Or is this something you can do automatically? There's quite a lot...


Thanks a bunch for pointing out these other issues. I'll get to those soon.

Yeah, we won't be able to do this on the backend so a resave will need to happen for this correction so we will do it with scripting and loops. I will set this up to be automatic but I want to be ensure we have all the corrections made first.

Thanks again for your help!

 
LazyPyro
beers 5290 º places 59 º 04:18 Wed 10/18/2017

No problem. I've found more for you in other alphabets too so I can keep posting them if it makes things quicker for you to fix. Browsing the top 50 of various European countries I copy and pasted some names of beers and searched for them with their native alphabet and also anglicized to see if the same results were returned.

Polish:
ł to l - e.g. Bałtycki and Baltycki don't return any results
ń to n - This one is odd, it's getting cut out of searches completely. For example do a search for "tlen" (correctly finds matches including ones spelled with the ń) then search for "tleń" - notice how the latter actually returns matches for "tle"? It's not taking that ń into account at all.
ę to e - Wędzony doesn't return any results but Wedzony does.
Some other letters in their alphabet seem to be working but only partially. For example the terms Śliwką and Sliwka return different results when they should probably be returning exactly the same.

Turkish:
s-cedilla and undotted-i need to be taken care of: ş to s, and ı to i
possibly c-cedilla as well if you haven't done French letters yet: ç to c, and maybe ğ to g too.
note that the s is similar looking to the Romanian one I pointed out before but is actually different.
For example a search for "turborg kis" does not find "Tuborg Kış"
"Tarcinli" does not find "Tarçınlı"

 
FatPhil
beers 21244 º places 832 º 04:28 Wed 10/18/2017

This should be scriptable, and find all the low-hanging and most egregious faults:

For each beer in database
If search for beer under its exact name doesn't find the beer
Flag that beer as needing attention, or better, automatically fix it

 
Marko
beers 10287 º places 537 º 04:37 Wed 10/18/2017

Originally posted by Bill Becker
Originally posted by Koelschtrinker
Sure, link works. but search for "Mühlen Kölsch" or just "Kölsch", that will bring up around 20 results while there are way more than 100 beers on RB with Kölsch in it


Why insist on using the umlauts?


Because in them yonder countries outside of Planet Mur'ca we have all those strange and wild and complicated characters that signify different sounds than "similar" characters y'all used to, which often carry different meaning to similar words without those letters and suchlike. And we'd like to get stuff correct and not just dumbed down for someone's "convenience".

Sorry for the snark, but doing something intentionally wrong because it's easier and a lot of people won't care should never, ever be done in any line of work.

 
Bitterbill
beers 2826 º places 25 º 08:01 Wed 10/18/2017

Originally posted by Marko
Originally posted by Bill Becker
Originally posted by Koelschtrinker
Sure, link works. but search for "Mühlen Kölsch" or just "Kölsch", that will bring up around 20 results while there are way more than 100 beers on RB with Kölsch in it


Why insist on using the umlauts?


Because in them yonder countries outside of Planet Mur'ca we have all those strange and wild and complicated characters that signify different sounds than "similar" characters y'all used to, which often carry different meaning to similar words without those letters and suchlike. And we'd like to get stuff correct and not just dumbed down for someone's "convenience".

Sorry for the snark, but doing something intentionally wrong because it's easier and a lot of people won't care should never, ever be done in any line of work.


For sure, using the correct way IS the way but I'm speaking more towards the folks, like me, who don't use the international keyboard and like the simplified way of searching beers without having to use special language characters.
Prost!